[cfe-commits] [PATCH] Adds the possibility to run ASTMatchFinder over arbitrary AST nodes.
Daniel Jasper
djasper at google.com
Wed Oct 24 04:02:41 PDT 2012
Otherwise looks good.
================
Comment at: include/clang/ASTMatchers/ASTMatchFinder.h:126
@@ -125,1 +125,3 @@
+ /// \brief Finds all matches on the given node.
+ ///
----------------
nit: maybe ".. on the given \c Node."
================
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:3193
@@ +3192,3 @@
+
+TEST(MatchFinder, CanMatchDeclarationsRecursively) {
+ EXPECT_TRUE(matchAndVerifyResultTrue("class X { class Y {}; };",
----------------
Could you create one negative test case as a smoke test?
http://llvm-reviews.chandlerc.com/D75
BRANCH
match-in-match
More information about the cfe-commits
mailing list