[cfe-commits] [Patch] Add -Wmissing-variable-declarations

[Eli Friedman]

On Fri, Oct 19, 2012 at 5:37 AM, Ed Schouten <ed at 80386.nl> wrote:
> Hi Eli,
>
> 2012/10/19 Eli Friedman <eli.friedman at gmail.com>:
>> In C (or C++ in an 'extern "C"' block), "bar" shouldn't have
>> UniqueExternalLinkage.  In C++, there isn't any reason to warn here:
>> "bar" can't be referenced from any other translation unit.  See
>> [basic.link]p8 in the standard.
>
> Oh, okay. I wasn't aware of that. I have to confess I'm more a C
> programmer than a C++ programmer. Anyway, I've updated the code and
> the testcases.
>
> http://80386.nl/pub/wmissing-variable-declarations.txt

Committed in r166498 (with a few minor changes).

-Eli