[cfe-commits] [PATCH] Fix some -Wunused-value false positives

[Matt Beaumont-Gay]

Thanks, r166468.

On Fri, Oct 19, 2012 at 5:40 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Fri, Oct 19, 2012 at 4:21 PM, Matt Beaumont-Gay <matthewbg at google.com> wrote:
>> We were missing some cases in Expr::isUnusedResultAWarning, causing us
>> to warn on the test case in the patch.
>
> Looks fine.
>
>> Any other Expr classes I should
>> add to that switch, or any reason the current behavior is actually
>> correct?
>
> There probably are other classes you should add, but I don't know what
> they are. :)

Well, if I find more false positives, I guess I'll figure it out :)