[cfe-commits] [llvm-commits] Reduce exception handling use in TableGen

Sean Silva silvas at purdue.edu
Mon Oct 22 10:14:40 PDT 2012


Hi Joerg, I was actually planning on doing this (I hadn't started
yet), but I guess you got to it first :) Thanks.

These patches LGTM.

-- Sean Silva

On Mon, Oct 22, 2012 at 4:08 AM, Joerg Sonnenberger
<joerg at britannica.bec.de> wrote:
> Hi all,
> the attached patch removes the majority of the exception handling
> dependency in TableGen. There is a small regression in the quality of
> error messages in one code path of the SetTheory implementation, where
> the location of the original expression is lost. This is a bit difficult
> to fix since the functions involved can be accessed directly as well and
> I am not sure how much value the location adds here.
>
> I have also included the parts needed for Clang, but those are
> unproblematic.
>
> One piece is missing and that's CodeGenDAGPatterns.cpp. That one
> actually uses the unwinding and resume behavior of exceptions to silence
> errors, I will bring up patches for that separately.
>
> Joerg
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the cfe-commits mailing list