[cfe-commits] r166188 - /cfe/trunk/lib/Sema/SemaInit.cpp

[Douglas Gregor]

On Oct 18, 2012, at 1:48 PM, Richard Smith <richard at metafoo.co.uk> wrote:

> On Thu, Oct 18, 2012 at 1:45 PM, Douglas Gregor <dgregor at apple.com> wrote:
> 
> On Oct 18, 2012, at 9:57 AM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> > Author: dblaikie
> > Date: Thu Oct 18 11:57:32 2012
> > New Revision: 166188
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=166188&view=rev
> > Log:
> > PR14021: Copy lookup results to ensure safe iteration.
> >
> > Within the body of the loop the underlying map may be modified via
> >
> >  Sema::AddOverloadCandidate
> >    -> Sema::CompareReferenceRelationship
> >    -> Sema::RequireCompleteType
> >
> > to avoid the use of invalid iterators the sequence is copied first.
> 
> Did you audit other uses of LookupConstructors to ensure that this is the only ticking time bomb in this area?
> 
> Perhaps we can fix all of these by taking a different approach (declaring all the implicit special members whenever we declare any of them).


Yes, that would work.

	- Doug

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121018/e9bdccf3/attachment.html>