[cfe-commits] [PATCH] Fix typo correction of one qualified name to another.

David Blaikie reviews at llvm-reviews.chandlerc.com
Mon Oct 8 14:17:26 PDT 2012


dblaikie added you to the CC list for the revision "Fix typo correction of one qualified name to another.".

When suggesting "foo::bar" as a correction for "fob::bar" we mistakenly
replaced only "bar" with "foo::bar" producing "fob::foo::bar" which was broken.

This corrects that replacement in as many places as I could find & provides
test cases for all those cases I could find a test case for. There are a couple
that don't seem to be reachable (one looks entirely dead, the other just
doesn't seem to ever get called with a namespace to namespace change).

http://llvm-reviews.chandlerc.com/D57

Files:
  include/clang/Sema/TypoCorrection.h
  lib/Sema/SemaCXXScopeSpec.cpp
  lib/Sema/SemaDecl.cpp
  lib/Sema/SemaDeclCXX.cpp
  lib/Sema/SemaExpr.cpp
  lib/Sema/SemaExprMember.cpp
  lib/Sema/SemaLookup.cpp
  lib/Sema/SemaTemplate.cpp
  test/FixIt/typo.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57.1.patch
Type: text/x-patch
Size: 10077 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121008/11aa9e97/attachment.bin>


More information about the cfe-commits mailing list