[cfe-commits] patch: make UsingDirective derive from Decl, not NamedDecl

Richard Smith richard at metafoo.co.uk
Fri Oct 5 18:43:27 PDT 2012


On Fri, Oct 5, 2012 at 2:21 AM, Nick Lewycky <nicholas at mxc.ca> wrote:

> This patch changes UsingDirectives to be derived from Decl instead of
> NamedDecl, and consequently removes the CXXUsingDirective DeclarationName.
>
> The way using directives are stored with this patch is to have a single
> pointer on each UsingDirectiveDecl that points to the previous declaration,
> and a pointer on TranslationUnit and Namespace DeclContexts that point to
> the last one in that chain. We don't need such pointers on other
> DeclContexts because they either can't hold using-directives or the lookup
> will be handled by Scope.
>
> Please review!


This looks good to me. Have you tested the patch with chained PCH (or
modules)?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121005/e7147a73/attachment.html>


More information about the cfe-commits mailing list