[cfe-commits] [PATCH] Add -fcatch-undefined-behavior runtime library

[Kostya Serebryany]

On Thu, Oct 4, 2012 at 10:48 PM, Richard Smith <richard at metafoo.co.uk>wrote:

> On Thu, Oct 4, 2012 at 3:36 AM, Kostya Serebryany <kcc at google.com> wrote:
>
>>
>> asan/tsan/msan generally avoid #including system headers, especially in
>> .h files.
>> Once you start porting the code to non-linux, you'll know why.
>> compiler-rt/lib/sanitizer_common contains lots of useful stuff that
>> allows you to avoid using system headers.
>> WDYT?
>>
>
> I was trying to steer clear of most system headers, but I've tried a bit
> harder now; new patch attached.
>
Cool!


>
> I'm not concerned about the includes in ubsan_diag.cc, since I intend for
> that code to be replaced in the medium term (and to be made
> user-replaceable -- some applications will want to provide their own
> reporting functionality). That only leaves <stdint.h> and <stddef.h>, which
> are both provided by Clang.
>

Mmm. Even with those two we had issues on windows, which forced us to
have include/sanitizer/common_interface_defs.h
Again, just for consistency (and for future windows porting) you may want
to use common_interface_defs.h instead of system headers.


> I'm not hugely interested in making the runtime build with any other
> compiler, since you need to have a Clang which can target your platform
> anyway in order for it to be useful.
>

>> Since these symbols are already extern "C", their mangled names are just
__ubsan_handle_divrem_overflow etc, so there's no difference from a
debugging perspective. Is there a benefit to moving them out of the
namespace?
No (other than consistency).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121005/1e59b5f7/attachment.html>