[cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

[Abramo Bagnara]

Il 05/10/2012 00:15, Chandler Carruth ha scritto:
> On Thu, Oct 4, 2012 at 3:12 PM, Chandler Carruth <chandlerc at google.com
> <mailto:chandlerc at google.com>> wrote:
> 
>     Can we get a test case for this?
> 
> 
> Also, not just for this, but for all of the source location fixes you're
> making?

This problem has been discussed a few time in past, but after discussion
on the list we failed to find a nice (and easy) solution for testing.

If things are now changed with tooling infrastructure, this would be
nice to hear. If someone is so kind to write a test for this patch we
will be happy to add the others replicating the same mechanism shown.

The testcase if very simple "void f(i) { }", what it should be tested is
that source range for ParamDecl matches the 'i'.

> We've got *lots* of source location bugs (as you're finding!) and we
> really need to start testing them in addition to fixing them.

FWIW we test massively also for this kind of regressions in our ECLAIR
huge internal testsuite.

-- 
Abramo Bagnara

BUGSENG srl - http://bugseng.com
mailto:abramo.bagnara at bugseng.com