[cfe-commits] Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4

Logan Chien tzuhsiang.chien at gmail.com
Tue Oct 2 22:34:01 PDT 2012


LGTM.

However, I think we can enhance the test cases a little.
1. Keep the void* test in builtins-arm.c for apcs-gnu ABI.
2. Add the unit test for va_list name mangling.

Sincerely,
Logan

ps. The attached patch is the revised patch with the updated
test cases.

On Thu, Sep 20, 2012 at 6:13 AM, Weiming Zhao <weimingz at codeaurora.org>wrote:

> Ping...
>
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by
> The Linux Foundation
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121003/fcdb59fe/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mangle-valist.cpp
Type: text/x-c++src
Size: 1436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121003/fcdb59fe/attachment.cpp>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: builtins-arm.c
Type: text/x-csrc
Size: 750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121003/fcdb59fe/attachment.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Bug-11709-Change-the-definition-of-va_list-to-meet-A.patch
Type: application/octet-stream
Size: 8948 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121003/fcdb59fe/attachment.obj>


More information about the cfe-commits mailing list