[cfe-commits] [Patch] Update handling of MemberExpr in the self initialization check

Richard Trieu rtrieu at google.com
Tue Oct 2 17:43:51 PDT 2012


Revision 165074

On Tue, Oct 2, 2012 at 4:53 PM, Richard Smith <richard at metafoo.co.uk> wrote:

> LGTM, but...
>
> +      // Warn when a non-static method call, followed by non-static member
> +      // field accesses, followed by a DeclRefExpr.
>
> Did you accidentally a verb here?
>
> On Tue, Oct 2, 2012 at 3:36 PM, Richard Trieu <rtrieu at google.com> wrote:
>
>> More changes to the SelfReferenceChecker with regards to MemberExpr's.
>>  This has better handling of class pointers and not warning when accessing
>> static members.  The basic idea is to treat each group of MemberExpr's
>> together instead of separately visiting each one.  This allows more
>> checking to be done than the previous way of just looking at the MemberExpr
>> above the DeclRefExpr.
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121002/63300b9a/attachment.html>


More information about the cfe-commits mailing list