[cfe-commits] PATCH: Remove llvm::InitializeAll* calls from SemaStmtAsm.cpp

[Chad Rosier]

No objection, Chris.  Thanks, Tom.  Committed revision 165025.

 Chad

On Oct 2, 2012, at 9:27 AM, Chris Lattner <clattner at apple.com> wrote:

> This seems really wrong to me too.  Chad, any objection to removing this?
> 
> -Chris
> 
> On Oct 2, 2012, at 8:39 AM, Tom Stellard <tom at stellard.net> wrote:
> 
>> Hi,
>> 
>> I noticed that the llvm:InitializeAll* functions are called from the
>> middle of the Sema::ActOnMSAsmStmt() function in Sema/SemaStmtAsm.cpp.
>> Is this necessary?  Shouldn't the program that uses libclang be
>> responsible for initializing the appropriate targets?
>> 
>> Additionally, calling these functions require that any program linked with
>> libclangSema also link against all the LLVM built targets.
>> 
>> I've attached a patch removing these function calls.  Any thoughts on
>> this?
>> 
>> Thanks,
>> Tom
>> <SemaStmtAsm-Remove-llvm-InitializeAll-Calls.patch>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits