[cfe-commits] [PATCH] Implement AST dumper for Decls

[Dmitri Gribenko]

On Tue, Oct 2, 2012 at 5:59 PM, Alexander Kornienko <alexfh at google.com> wrote:
> So I'm definitely for using FileCheck in this case, but it's only me, others
> may disagree.

I'm in favor of ASTMatchers-based tests for anything dumping related,
based on my experience of maintaining
test/Index/annotate-comments.cpp.  Any small change to the testcases
forces a change of line numbers for everything that follows it (half
of tests, on average).  With ASTMatchers-based tests we can keep all
logically related tests in a single file and keep the test case close
to the expected output while ensuring that different tests are
isolated from each other.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/