[cfe-commits] [PATCH] C++11 matchers

Manuel Klimek reviews at llvm-reviews.chandlerc.com
Mon Oct 1 05:36:55 PDT 2012


  apart from that, lg


================
Comment at: unittests/ASTMatchers/ASTMatchersTest.h:55
@@ -55,1 +54,3 @@
+                                              bool ExpectMatch,
+                                              std::string Arg) {
   bool Found = false;
----------------
Either make that const std::string& or llvm::StringRef.
Also, I'd call it CompileArg (Arg might mean anything).


http://llvm-reviews.chandlerc.com/D46



More information about the cfe-commits mailing list