[cfe-commits] [patch] Add codegen support for __uuidof

[Nico Weber]

On Mon, Oct 1, 2012 at 4:12 PM, Kim Gräsman <kim.grasman at gmail.com> wrote:
> Hi Nico,
>
> On Mon, Oct 1, 2012 at 8:56 AM, Nico Weber <thakis at chromium.org> wrote:
>>
>> The name of the symbol generated for __uuidof constants seems to be an
>> implementation detail, so I just made up a mangling ("__uuid_"
>> followed by the contents of the uuid, see GetAddrOfIIDDescriptor()).
>
> It's been years since I did any COM, and I might be missing a nuance,
> but should the method name really be GetAddrOfIIDDescriptor? I think
> __declspec(uuid()) can apply to non-interface constructs as well,
> typically coclasses. Singling it out as an IID might be too narrow,
> even if IID and CLSID are type compatible in the C++ sense.
>
> How about GetAddrOfUUIDDescriptor?

Done.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uuid.patch
Type: application/octet-stream
Size: 14825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121001/65592001/attachment.obj>