[cfe-commits] r164739 - /cfe/trunk/tools/Makefile

[Bill Wendling]

Hi David,

I think I might have addressed your concerns with my newest check-in. Please take a look and let me know.

-bw

On Sep 27, 2012, at 2:37 AM, David Blaikie <dblaikie at gmail.com> wrote:

> Right, sorry, I didn't mean that this would be predicated on
> a 'release' build (indeed lots of people work with release+asserts
> builds for speed & I think they still run the regression tests that
> need those tools)
> 
> Perhaps to rephrase: could there be a target that builds the same that
> are installed by the 'install' target (& if it's depending on test
> tools, that seems like a bug)? Seems like a reasonable target to have.
> From: Bill Wendling
> Sent: 9/27/2012 9:21 AM
> To: David Blaikie
> Cc: cfe-commits at cs.uiuc.edu
> Subject: Re: [cfe-commits] r164739 - /cfe/trunk/tools/Makefile
> I'm not sure. I could imagine them wanting release builds of the
> testing stuff, so I didn't want to mess with that...But I can be
> convinced otherwise. :)
> 
> -bw
> 
> On Sep 26, 2012, at 11:08 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
>> I don't know, but would it make more or less sense to just have a build
>> target that just builds the release binaries, rather than a variable?
>> From: Bill Wendling
>> Sent: 9/27/2012 3:14 AM
>> To: cfe-commits at cs.uiuc.edu
>> Subject: [cfe-commits] r164739 - /cfe/trunk/tools/Makefile
>> Author: void
>> Date: Wed Sep 26 19:11:09 2012
>> New Revision: 164739
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=164739&view=rev
>> Log:
>> Use a variable to stop us from building clang testing tools.
>> <rdar://problem/11202465>
>> 
>> Modified:
>>   cfe/trunk/tools/Makefile
>> 
>> Modified: cfe/trunk/tools/Makefile
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/Makefile?rev=164739&r1=164738&r2=164739&view=diff
>> ==============================================================================
>> --- cfe/trunk/tools/Makefile (original)
>> +++ cfe/trunk/tools/Makefile Wed Sep 26 19:11:09 2012
>> @@ -14,6 +14,10 @@
>> DIRS := driver libclang c-index-test arcmt-test c-arcmt-test diagtool \
>>        clang-check
>> 
>> +ifeq ($(CLANG_NO_TEST_TOOLS),YES)
>> +DIRS := driver libclang
>> +endif
>> +
>> # Recurse into the extra repository of tools if present.
>> OPTIONAL_DIRS := extra
>> 
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits