[cfe-commits] r164790 - in /cfe/trunk: lib/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/DirectIvarAssignment.cpp test/Analysis/objc-properties.m

[Jordan Rose]

>>> +  @property (assign, nonatomic) MyClass* Z; // non synthesized, implemented
>> 
>> Z's getter is still synthesized, which means this test case isn't testing the case where the ObjCPropertyDecl doesn't have an associated ivar.
> 
> maybe the comment is not correct.. the ivar is not synth here, _Z will be used, no?

Yes. The ivar is not synthesized, the getter is. (And the setter is explicitly defined.) The comment is ambiguous and I wasn't sure what it was trying to test.


>>> +  @property (readonly) id nonSynth;  // non synthesized, explicitly implemented to return ivar with expected name
>> 
>> Ditto. You have to implement the getter for readonly and both getter and setter for readwrite in order to turn off ivar matching/synthesis.
>> 
> this one is readonly and I did implement the getter.

Oops, read it wrong. Sorry!