[cfe-commits] [PATCH] Change wording of the warning about 'long long' being an extension

[Dmitri Gribenko]

On Mon, Sep 24, 2012 at 9:56 PM, Richard Smith <richard at metafoo.co.uk> wrote:
>> I'm terribly sorry for breakage, but this makes us warn on long long
>> while self-hosting because we pass -pedantic -Wno-long-long, but
>> "'long long' is a C++11 extension" is in CXX11 group, not in LongLong
>> group.
>>
>> How to handle this?  Should I back out?
>
>
> The best way to fix this is to add this warning to both the LongLong group
> and the CXX11 group:
>
> def CXX11LongLong : DiagGroup<"c++11-long-long">;
> def LongLong : DiagGroup<"long-long", [CXX11LongLong]>;
> def CXX11 : DiagGroup<"c++11-extensions", [CXX11ExtraSemi, CXX11LongLong]>;
>
> Please back out the other patch if you can't get this fix in reasonably
> soon.

I didn't know that warning groups are not a tree, but a DAG.  Thank
you for the advice!

Committed r164546.

Sorry for the breakage.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/