[cfe-commits] [PATCH] Disable source fortification on Darwin with AddressSanitizer

Alexander Potapenko glider at google.com
Thu Sep 20 03:11:51 PDT 2012


r164299, thank you!

On Thu, Sep 20, 2012 at 10:17 AM, Eric Christopher <echristo at apple.com> wrote:
>
> On Sep 19, 2012, at 3:04 AM, Alexander Potapenko <glider at google.com> wrote:
>
>> Hi all,
>>
>> Because source fortification has been turned on in Xcode headers
>> recently, we have to disable it when building the code with
>> AddressSanitizer.
>> The proposed patch (see attached) defines _FORTIFY_SOURCE=0 if
>> -faddress-sanitizer is passed to the compiler.
>> Because other systems are not affected by the change, I've decided to
>> run the test only on Darwin (and introduced the 'system-darwin' config
>> feature)
>>
>> Codereview link: https://codereview.appspot.com/6534045
>
> LGTM.
>
> -eric



-- 
Alexander Potapenko
Software Engineer
Google Moscow



More information about the cfe-commits mailing list