[cfe-commits] r164143 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/Analysis/additive-folding.cpp test/Sema/compare.c test/Sema/outof-range-constant-compare.c te

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Sep 19 07:12:07 PDT 2012


On 18 September 2012 20:56, Fariborz Jahanian <fjahanian at apple.com> wrote:
>
> On Sep 18, 2012, at 3:27 PM, Jordan Rose wrote:
>
> Just curious: were these unparenthesized actually causing failures for you?
>
>
> Yes, it was giving me the warning:
> comparison of literal 10 with expression of type 'bool' is always false
>
> This is because it is expanded into:
> if (!total == 10) { return 1; };
>
> In c++, (but not in c), comparing a bool to 10.

Should the assert definition in that file be changed instead?

> - Fariborz
>

Cheers,
Rafael



More information about the cfe-commits mailing list