[cfe-commits] [PATCH] Mark ARCMT test cases as XFAIL on ARM

[David Tweed]

-----Original Message-----
From: 陳韋任 (Wei-Ren Chen) [mailto:chenwj at iis.sinica.edu.tw] 
Sent: 18 September 2012 13:27
To: David Tweed
Cc: '陳韋任 (Wei-Ren Chen)'; James Molloy; cfe-commits at cs.uiuc.edu
Subject: Re: [PATCH] Mark ARCMT test cases as XFAIL on ARM

On Tue, Sep 18, 2012 at 01:12:57PM +0100, David Tweed wrote:
> Hi Wei-Ren,
> 
> To take a step backwards: are you seeing failures on all the tests you've XFAIL'd? I see a couple of test failures where it reports issues with the target triple for 3 cases:

|  Attach is `make check-all` log. I just mark those ARC test cases appear 
| in "Failing Tests" section as XFAIL.

I'm probably under-caffeinated, but I don't see any of the files in your patch appearing as failures in the test output you've attached.

> GC-check-warn-nsmalloc.m

|  This one is marked as "XFAIL: *".

Right you are.

> arc-ivar-layout.m
> debug-info-crash-2.m
  
|   I don't see above two files in my clang/test/ARCMT directory. What's
| your svn number? Mine is r164117.

They're in CodeGenObjC/ on my r164117. I _think_ they're arc stuff, though I'm not familiar with Obj-C at all.
 
> All the others pass. If we can figure out that it's a specific platform-unfixable issue peculiar to arm*-linux-eabi then it would be fine to XFAIL such tests on ARM. (Clearly if it's actually something fixable it ought to be fixed :-) ) But I don't think we want to XFAIL tests that are passing.

|  Yes. As I am not familiar with ARC stuff, I would prefer to ask clang
|community (or you guys ;)). Any idea on how to figure out what ARC test
|cases are fixable rather than marking them as XFAIL?

Certainly, although it'd also be interesting to know what it is that makes them fail for you. Below is the subset of the output for me, with mostly passes:

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

XFAIL: Clang :: ARCMT/GC-check-warn-nsalloc.m (1 of 5381)
PASS: Clang :: ARCMT/GC-check.m (2 of 5381)
PASS: Clang :: ARCMT/api.m (3 of 5381)
PASS: Clang :: ARCMT/GC-no-arc-runtime.m (4 of 5381)
PASS: Clang :: ARCMT/GC-no-finalize-removal.m (5 of 5381)
PASS: Clang :: ARCMT/GC.m (6 of 5381)
PASS: Clang :: ARCMT/assign-prop-no-arc-runtime.m (7 of 5381)
PASS: Clang :: ARCMT/atautorelease-2.m (8 of 5381)
PASS: Clang :: ARCMT/assign-prop-with-arc-runtime.m (9 of 5381)
PASS: Clang :: ARCMT/atautorelease-check.m (10 of 5381)
PASS: Clang :: ARCMT/atautorelease-3.m (11 of 5381)
PASS: Clang :: ARCMT/check-api.m (12 of 5381)
PASS: Clang :: ARCMT/atautorelease.m (13 of 5381)
PASS: Clang :: ARCMT/autoreleases.m (14 of 5381)
PASS: Clang :: ARCMT/checking.m (15 of 5381)
PASS: Clang :: ARCMT/cxx-checking.mm (16 of 5381)
PASS: Clang :: ARCMT/dealloc.m (17 of 5381)
PASS: Clang :: ARCMT/cxx-rewrite.mm (18 of 5381)
PASS: Clang :: ARCMT/dispatch.m (19 of 5381)
PASS: Clang :: ARCMT/check-with-serialized-diag.m (20 of 5381)
PASS: Clang :: ARCMT/init.m (21 of 5381)
PASS: Clang :: ARCMT/migrate-emit-errors.m (22 of 5381)
PASS: Clang :: ARCMT/migrate-plist-output.m (23 of 5381)
PASS: Clang :: ARCMT/driver-migrate.m (24 of 5381)
PASS: Clang :: ARCMT/no-canceling-bridge-to-bridge-cast.m (25 of 5381)
PASS: Clang :: ARCMT/migrate-space-in-path.m (26 of 5381)
PASS: Clang :: ARCMT/nonobjc-to-objc-cast-2.m (27 of 5381)
PASS: Clang :: ARCMT/migrate.m (28 of 5381)
PASS: Clang :: ARCMT/nonobjc-to-objc-cast.m (29 of 5381)
PASS: Clang :: ARCMT/objcmt-boxing.m (30 of 5381)
PASS: Clang :: ARCMT/objcmt-subscripting-literals-in-arc.m (31 of 5381)
PASS: Clang :: ARCMT/objcmt-subscripting-literals.m (32 of 5381)
PASS: Clang :: ARCMT/objcmt-subscripting-unavailable.m (33 of 5381)
PASS: Clang :: ARCMT/releases-driver.m (34 of 5381)
PASS: Clang :: ARCMT/remove-dealloc-method.m (35 of 5381)
PASS: Clang :: ARCMT/releases.m (36 of 5381)
PASS: Clang :: ARCMT/remove-dealloc-zerouts.m (37 of 5381)
PASS: Clang :: ARCMT/objcmt-numeric-literals.m (38 of 5381)
PASS: Clang :: ARCMT/remove-statements.m (39 of 5381)
PASS: Clang :: ARCMT/safe-arc-assign.m (40 of 5381)
PASS: Clang :: ARCMT/retains.m (41 of 5381)
PASS: Clang :: ARCMT/rewrite-block-var.m (42 of 5381)
PASS: Clang :: ARCMT/with-arc-mode-check.m (43 of 5381)
PASS: Clang :: ARCMT/verify.m (44 of 5381)
PASS: Clang :: ARCMT/with-arc-mode-modify.m (45 of 5381)
PASS: Clang :: ARCMT/with-arc-mode-migrate.m (46 of 5381)

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

Thanks,
David Tweed