[cfe-commits] [PATCH] Make all VariadicDynCast-Expr-matchers StatementMatchers

Daniel Jasper reviews at llvm-reviews.chandlerc.com
Tue Sep 18 03:07:01 PDT 2012


Hi klimek,

Having Expr-subclass-matchers being VariadicDynCast-Expr-matchers does not provide additional type safety and just makes using them harder. In the clang AST, expressions are always statements and an expression matcher can be used anywhere, a statement matcher is expected. Any given matcher definition still has at least one noun.

http://llvm-reviews.chandlerc.com/D43

Files:
  include/clang/ASTMatchers/ASTMatchers.h
  unittests/ASTMatchers/ASTMatchersTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43.1.patch
Type: text/x-patch
Size: 17362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120918/f7577ce7/attachment.bin>


More information about the cfe-commits mailing list