[cfe-commits] Patch to fix warning on qualified typedef with 'unused' attribute

Douglas Gregor dgregor at apple.com
Thu Sep 13 22:12:16 PDT 2012


On Sep 11, 2012, at 8:06 AM, Jason Haslam <jason.haslam at gmail.com> wrote:

> On Sep 10, 2012, at 11:38 PM, Douglas Gregor <dgregor at apple.com> wrote:
> 
>> 
>> On Sep 10, 2012, at 2:53 PM, Jason Haslam <jason.haslam at gmail.com> wrote:
>> 
>>> This test case incorrectly warns because the diagnostic fails to look through the qualifier when it checks the typedef's 'unused' attribute:
>>> 1 namespace NS { typedef int Int __attribute__((unused)); }
>>> 2 void f() {
>>> 3   NS::Int i; // bogus unused variable warning
>>> 4 }
>>> 
>>> The attached patch contains a fix and test case.
>> 
>> LGTM, thanks!
> 
> Thanks for looking at this. I don't have commit access. Could somebody commit it for me?

r163874.

	- Doug

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120913/4ec8bc9c/attachment.html>


More information about the cfe-commits mailing list