[cfe-commits] [PATCH] Wrong crtbegin/crtend pair used for PIE on Android

[Evgeniy Stepanov]

Thanks!
Committed as r163500.

On Mon, Sep 10, 2012 at 1:42 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Mon, Sep 10, 2012 at 2:33 AM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> On Thu, Sep 6, 2012 at 1:50 PM, Evgeniy Stepanov
>> <eugeni.stepanov at gmail.com> wrote:
>> > Hi,
>> >
>> > current clang driver picks the wrong crtbegin/crtend combination for
>> > PIE binaries on android. See attached fix for details.
>>
>> Not an Android or Driver expert, but this looks good to me.
>>
>> Maybe expand the patch description a little by explaining which
>> crtbegin/crtend was picked before and which is the correct one?
>
>
> Agreed, and LGTM. =] Thanks for the nice test cases here.
>