[cfe-commits] r163429 - /cfe/trunk/tools/clang-check/ClangCheck.cpp

[Douglas Gregor]

Sent from my iPhone

On Sep 7, 2012, at 6:44 PM, Alexander Kornienko <alexfh at google.com> wrote:

> Author: alexfh
> Date: Fri Sep  7 17:44:34 2012
> New Revision: 163429
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=163429&view=rev
> Log:
> Fixed http://llvm.org/bugs/show_bug.cgi?id=13777
> 
> Modified:
>    cfe/trunk/tools/clang-check/ClangCheck.cpp
> 
> Modified: cfe/trunk/tools/clang-check/ClangCheck.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-check/ClangCheck.cpp?rev=163429&r1=163428&r2=163429&view=diff
> ==============================================================================
> --- cfe/trunk/tools/clang-check/ClangCheck.cpp (original)
> +++ cfe/trunk/tools/clang-check/ClangCheck.cpp Fri Sep  7 17:44:34 2012
> @@ -58,7 +58,9 @@
>     "ast-dump-filter",
>     cl::desc(Options->getOptionHelpText(options::OPT_ast_dump_filter)));
> 
> -namespace {
> +// Anonymous namespace here causes problems with gcc <= 4.4 on MacOS:
> +// http://llvm.org/bugs/show_bug.cgi?id=13777
> +// namespace {

How about just putting it in the clang namespace? At the very least, please delete the commented-out lines. 

> class ActionFactory {
> public:
>   clang::ASTConsumer *newASTConsumer() {
> @@ -71,7 +73,7 @@
>     return new clang::ASTConsumer();
>   }
> };
> -}
> +// }
> 
> int main(int argc, const char **argv) {
>   ActionFactory Factory;
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits