[cfe-commits] [PATCH] Change counter-intuitive behavior of isDerivedFrom
Sean Silva
reviews at llvm-reviews.chandlerc.com
Fri Sep 7 12:12:02 PDT 2012
This patch is *pure evil* since it subtly changes the meaning of
existing code. It's better to just come up with completely new names
so that existing code, instead of silently misbehaving, will instead
fail to compile.
I think that isA is clearer for the non-strict base-of/derived-from
anyway: much less error prone. I think it would be good to have a
patch that just renames isBaseOf to isA.
In a later patch, you can then introduce a matcher for strict
base-of/derived-from notion.
--Sean Silva
http://llvm-reviews.chandlerc.com/D37
More information about the cfe-commits
mailing list