[cfe-commits] [PATCH] cindex.py - Make the compatibility check in cindex.py explicit

[Gregory Szorc]

On 9/5/12 3:02 PM, Tobias Grosser wrote:
>>>>> Another idea, I was playing with can be seen in the attached patch. I
>>>>> did not finish thinking about it, so I don't yet submit it as an
>>>>> official patch, but you may want to have a look.
>>>> That's a great idea! User-friendly and actionable error messages are
>>>> always good.
>>>
>>> Great. The patch still needs some love . We need e.g. to decide if we
>>> want the version info being part of a separate table or if it should
>>> be merged with the method signature table. What do you think?
>> I think it should live in the method signature table. Related data
>> should live together.
>
> Makes sense. I attached an updated patch. It should work and may be OK 
> to commit. I started to think if it would be better to make each entry 
> an object of a FuncDescription class. This would remove this
> ugly use of item[0], ..., item[4]. I will give this a rest for now. 
> Feel free to commit these changes in case you like them.
That doesn't bother me too much. If you want to change it, I'd use a 
namedtuple rather than a full class.