[cfe-commits] [PATCH] Improve handling of DLL import/export attributes
John McCall
rjmccall at apple.com
Tue Sep 4 12:53:48 PDT 2012
On Sep 4, 2012, at 11:47 AM, Aaron Ballman wrote:
> On Mon, Sep 3, 2012 at 11:39 AM, João Matos
> <reviews at llvm-reviews.chandlerc.com> wrote:
>>
>> All fixed. Thanks a lot for the reviews so far. I will try to get Aaron to review the DLL stuff.
>
>> Index: include/clang/AST/DeclCXX.h
>> ===================================================================
>> --- include/clang/AST/DeclCXX.h
>> +++ include/clang/AST/DeclCXX.h
>> @@ -779,6 +779,20 @@
>> return method_iterator(decls_end());
>> }
>>
>> + /// Iterator access to static data members. The method iterator visits
>> + /// all static data members of the class.
>> + typedef specific_decl_iterator<VarDecl> static_data_iterator;
>> +
>> + /// static_data_begin - Static data member begin iterator. Iterates in the
>> + // order the static data members were declared.
>> + static_data_iterator static_data_begin() const {
>> + return static_data_iterator(decls_begin());
>> + }
>> + /// static_data_end - Static data member end iterator.
>> + static_data_iterator static_data_end() const {
>> + return static_data_iterator(decls_end());
>> + }
>> +
>
> Is it really iterating only the static data? From the looks of
> things, this is iterating all VarDecl objects, regardless of storage
> class.
Non-static data members are FieldDecls, not VarDecls.
John.
More information about the cfe-commits
mailing list