[cfe-commits] r163099 - in /cfe/trunk: include/clang-c/Index.h tools/libclang/CIndex.cpp tools/libclang/CXCursor.cpp

Chandler Carruth chandlerc at google.com
Tue Sep 4 09:19:43 PDT 2012


On Sun, Sep 2, 2012 at 8:23 PM, Joao Matos <ripzonetriton at gmail.com> wrote:

> Author: triton
> Date: Sun Sep  2 19:23:40 2012
> New Revision: 163099
>
> URL: http://llvm.org/viewvc/llvm-project?rev=163099&view=rev
> Log:
> Added a new cursor for SEHLeaveStmt to libclang.
>

Please revert this, it was not fully reviewed on the list. It has zero
tests and is a potential addition to the C API which we must never regress.
I've CC-ed people who could actually review and approve this type of change.


>
> Modified:
>     cfe/trunk/include/clang-c/Index.h
>     cfe/trunk/tools/libclang/CIndex.cpp
>     cfe/trunk/tools/libclang/CXCursor.cpp
>
> Modified: cfe/trunk/include/clang-c/Index.h
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang-c/Index.h?rev=163099&r1=163098&r2=163099&view=diff
>
> ==============================================================================
> --- cfe/trunk/include/clang-c/Index.h (original)
> +++ cfe/trunk/include/clang-c/Index.h Sun Sep  2 19:23:40 2012
> @@ -1975,7 +1975,9 @@
>     */
>    CXCursor_DeclStmt                      = 231,
>
> -  CXCursor_LastStmt                      = CXCursor_DeclStmt,
> +  CXCursor_SEHLeaveStmt                  = 232,
> +
> +  CXCursor_LastStmt                      = CXCursor_SEHLeaveStmt,
>
>    /**
>     * \brief Cursor that represents the translation unit itself.
>
> Modified: cfe/trunk/tools/libclang/CIndex.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CIndex.cpp?rev=163099&r1=163098&r2=163099&view=diff
>
> ==============================================================================
> --- cfe/trunk/tools/libclang/CIndex.cpp (original)
> +++ cfe/trunk/tools/libclang/CIndex.cpp Sun Sep  2 19:23:40 2012
> @@ -3559,6 +3559,8 @@
>        return createCXString("CXXForRangeStmt");
>    case CXCursor_SEHTryStmt:
>        return createCXString("SEHTryStmt");
> +  case CXCursor_SEHLeaveStmt:
> +      return createCXString("SEHLeaveStmt");
>    case CXCursor_SEHExceptStmt:
>        return createCXString("SEHExceptStmt");
>    case CXCursor_SEHFinallyStmt:
>
> Modified: cfe/trunk/tools/libclang/CXCursor.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CXCursor.cpp?rev=163099&r1=163098&r2=163099&view=diff
>
> ==============================================================================
> --- cfe/trunk/tools/libclang/CXCursor.cpp (original)
> +++ cfe/trunk/tools/libclang/CXCursor.cpp Sun Sep  2 19:23:40 2012
> @@ -197,6 +197,10 @@
>      K = CXCursor_SEHTryStmt;
>      break;
>
> +  case Stmt::SEHLeaveStmtClass:
> +    K = CXCursor_SEHLeaveStmt;
> +    break;
> +
>    case Stmt::SEHExceptStmtClass:
>      K = CXCursor_SEHExceptStmt;
>      break;
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120904/7f40169f/attachment.html>


More information about the cfe-commits mailing list