[cfe-commits] [PATCH] Improve handling of DLL import/export attributes

Dmitri Gribenko reviews at llvm-reviews.chandlerc.com
Mon Sep 3 08:26:01 PDT 2012


  This patch LGTM, but I don't think I know enough about windows dll attributes to actually accept this.


================
Comment at: test/Sema/dllimport-dllexport.cpp:14
@@ +13,3 @@
+
+// This should really be an error, but since MSVC does even generate
+// a diagnostic in this case, we only generate a warning to not break
----------------
does *not*


http://llvm-reviews.chandlerc.com/D34



More information about the cfe-commits mailing list