[cfe-commits] [llvm-commits] [PATCH] Rename llvm::Triple::ANDROIDEABI to llvm::Triple::Android

[Evgeniy Stepanov]

The following chunk looks weird to me.

   bool isEABI() const {
     StringRef Env =
       getContext().getTargetInfo().getTriple().getEnvironmentName();
-    return (Env == "gnueabi" || Env == "eabi" || Env == "androideabi");
+    return (Env == "gnueabi" || Env == "eabi" ||
+            Env == "android" || Env == "androideabi");
   }

Now we have isEABI() == true for i686-linux-android.
I'd rather we kept more information about the original triple by
having both android and androideabi environments, and a helper
function isAndroid() somewhere.

On Sun, Sep 2, 2012 at 1:48 PM, Logan Chien <tzuhsiang.chien at gmail.com> wrote:
> Thanks.  Commited as r163087, r163088.
> -Logan
>
>
>
> On Fri, Aug 31, 2012 at 5:25 PM, Anton Korobeynikov
> <anton at korobeynikov.info> wrote:
>>
>> > This is because that we are using "StartsWith" to translate environment
>> > name
>> > (eg. andriodeabi, android, gnueabi, ...etc) into
>> > Triple::EnvironmentType.
>> > Thus,
>> > I believe it won't case backward compatibility issue.  :-)
>> Ok. LGTM then :)
>>
>> --
>> With best regards, Anton Korobeynikov
>> Faculty of Mathematics and Mechanics, Saint Petersburg State University
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>