[cfe-commits] [PATCH] Improve handling of DLL import/export attributes

[Dmitri Gribenko]

================
Comment at: lib/Sema/SemaDeclCXX.cpp:5

----------------
Star goes to the identifier.

================
Comment at: test/Sema/dllimport-dllexport.cpp:14
@@ +13,3 @@
+
+typedef int __attribute__((dllexport)) type6; // expected-warning{{'dllexport' attribute only applies to variables, functions and tag types}}
+
----------------
João Matos wrote:
> Dmitri Gribenko wrote:
> > Is there a reason this is not an error?
> > 
> I didn't introduce this behaviour, so I'm not sure what the original reason was to make it a warning. But I just tested it in MSVC and it does not even emit a warning in this case (with /Wall), so that might be why.
I see.  Could you please add a comment about MSVC behavior to the test case then?



http://llvm-reviews.chandlerc.com/D34