[cfe-commits] [llvm-commits] [PATCH] Rename llvm::Triple::ANDROIDEABI to llvm::Triple::Android

[Logan Chien]

Hi Anton,

  If you have some concern with the triple parser change, then I'm
sure that clang or llc still supports arm-linux-androideabi, the test
cases with androideabi has been remained unchanged.  And we
are still passing every llvm/clang regression test.  Please let me know
if you have other concerns?  Thanks.

Sincerely,
- Logan

On Fri, Aug 31, 2012 at 4:32 PM, Anton Korobeynikov <anton at korobeynikov.info
> wrote:

> >   To avoid the confusion of Android environment on MIPS/X86
> architecture, I
> > believe that
> > it is better to replace llvm::Triple::ANDROIDEABI with
> > llvm::Triple::Android.  So that we
> > can use mipsel-linux-android instead of mipsel-linux-androideabi (this
> > applies to x86 as well).
> > Please review.  Thanks for your help.
> This seems to break backward compatibility. You need to handle
> androideabi at least on ARM.
>
> --
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120831/0f861122/attachment.html>