[cfe-commits] [Patch] Visually update -ast-dump

[Alexander Kornienko]

On Thu, Aug 30, 2012 at 3:06 PM, Richard Trieu <rtrieu at google.com> wrote:

> On Thu, Aug 30, 2012 at 1:06 PM, Alexander Kornienko <alexfh at google.com>wrote:
>
>> Looks nice!
>>
>> I'm not the one to approve it, but here are few minor comments regarding
>> the patch (btw, it would be much more convenient with
>> http://llvm-reviews.chandlerc.com/
>>
> I haven't been paying attention to the review options for this mailing
> list.  I'll try sending future versions of this patch there.
>
I missed the "this is a work in progress" part ;)


>  ;):
>>
>  http://xkcd.com/541/
>
;)


> Besides that, are you going to deal with AST dumping further? I was
>> planning to start replacing current Decl dumping with something more
>> informative (based on current -ast-dump-xml implementation, probably) at
>> some point. It would be nice to try to avoid conflicts ;)
>>
>> I did notice the FIXME's in DumpDeclarator().  I'm aware of it, but
> haven't started any work on it.  I'll ping you if I start working in that
> direction.  Are you considering starting work on it soon?
>
It could be next week, but I'm not sure yet. I can safely delay this work
until you're done with your changes.


-- 
Regards,
Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120830/96d867e1/attachment.html>