[cfe-commits] [PATCH] Use custom ABIInfo for le32/PNaCl argument codegen

Eli Friedman eli.friedman at gmail.com
Thu Aug 30 15:14:58 PDT 2012


On Thu, Aug 30, 2012 at 2:05 PM, Derek Schuff <dschuff at google.com> wrote:
> This patch uses a new ABIInfo implementation specific to the le32
> target, rather than falling back to DefaultABIInfo. Its behavior is
> basically the same, but it also allows the regparm argument attribute.
> It also includes basic tests for argument codegen and attributes.
> Please review, thanks.

Do you have some sort of ABI spec you're writing this against?  Some
of the regparm code seems a little weird, but I can't say it's wrong
without anything to compare against.

+// PR7025

Please update the comments in the tests.

-Eli



More information about the cfe-commits mailing list