[cfe-commits] [PATCH] objc_sync_enter and objc_sync_exit function signatures

Aaron Ballman aaron at aaronballman.com
Thu Aug 30 12:14:21 PDT 2012


On Mon, Aug 27, 2012 at 3:50 PM, jahanian <fjahanian at apple.com> wrote:
>
> On Aug 27, 2012, at 12:19 PM, Joseph Ranieri wrote:
>
>> While browsing the implementation of @synchronized, I noticed that the
>> signatures in Clang for objc_sync_enter and objc_sync_exit didn't
>> match the signatures in the objc4 sources on opensource.apple.com
>> (http://www.opensource.apple.com/source/objc4/objc4-532/runtime/objc-sync.h).
>> Attached is a patch that updates CGObjCMac to correct the return type.
>> The rewriter also has this problem, but since I am less familiar with
>> the rewriter I have attached it as a separate patch.
>
> Rewriter part lgtm.

Two LGTMs, any disagreements?  If not, I'll commit.

~Aaron



More information about the cfe-commits mailing list