[cfe-commits] [PATCH] Add android triple to GCC Installation Detector

[Logan Chien]

Thanks for your comments.  Here's the new patch.  The test cases is included
now.

However, IMHO, this new test case is not very reliable.  The
GCCInstallationDetector
will search for system root (i.e. /usr) for latest (newest) GCC, thus "-B"
option may not
be used if we have older GCC version in the test case.  Maybe we have to
revise the
"-B" implementation as well.

Any further suggestion?  Thanks.

Sincerely,
Logan

On Wed, Aug 29, 2012 at 3:23 PM, Chandler Carruth <chandlerc at google.com>wrote:

> If you want to teach the Clang driver about the android toolchains, you'll
> need to add some test cases for them. You can find the test case strategy
> by looking at the tests for Linux and FreeBSD; I think they're pretty
> comprehensive at this point.
>
>
> On Wed, Aug 29, 2012 at 12:19 AM, Logan Chien <tzuhsiang.chien at gmail.com>wrote:
>
>> Hi,
>>
>>   Currently, the GCCInstallationDetector is not looking for
>> mipsel-linux-android and
>> i686-linux-android.  As the result, the clang driver can't use Android
>> Mips/X86 toolchain
>> even if -B is specified.  I hope this patch can solve this issue.  Please
>> review.  Thanks.
>>
>> Sincerely,
>> Logan
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120829/5ed5e94f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Add-Android-triple-for-X86-Mips-GCC-detection.patch
Type: application/octet-stream
Size: 5711 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120829/5ed5e94f/attachment.obj>