[cfe-commits] PATCH: Large re-working of bitfield IR-gen, and a fix for PR13691

[Eric Christopher]

On Aug 28, 2012, at 5:33 PM, Chandler Carruth <chandlerc at google.com> wrote:

> Will we find ourselves completely reimplementing it to support MS-style packed bitfields?
> 
> I don't know anything about MS-style packed bitfields, but I'll go digging....
> 

FWIW here I think the answer is "no". ASTRecordLayout should handle all of the offsets of the fields and bitfields in the struct including the final alignment of any fields (it's somewhat obnoxious here) and then Chandler's code will just grab the bit offsets where each particular field starts according to the layout. I think that's all that'd be required, but I've not looked into it in great detail.

-eric