[cfe-commits] [PATCH] Keep history of macro definitions and #undefs

[Chandler Carruth]

  I'll leave the real review to Doug, but I have a tiny style nit. ;]


================
Comment at: tools/clang/lib/Frontend/PrintPreprocessedOutput.cpp:571-574
@@ -570,5 +570,6 @@
   do PP.Lex(Tok);
   while (Tok.isNot(tok::eof));
 
-  SmallVector<id_macro_pair, 128>
-    MacrosByID(PP.macro_begin(), PP.macro_end());
+  SmallVector<id_macro_pair, 128> MacrosByID;
+  for (Preprocessor::macro_iterator It = PP.macro_begin(), End = PP.macro_end();
+       It != End; ++It) {
----------------
FYI, please use the conventional naming for loop iterators in Clang/LLVM: I and E.


http://llvm-reviews.chandlerc.com/D28