[cfe-commits] [PATCH] fix PR13704

Michael Liao michael.liao at intel.com
Tue Aug 28 09:57:16 PDT 2012


On Tue, 2012-08-28 at 09:34 -0700, Matt Beaumont-Gay wrote:
> On Mon, Aug 27, 2012 at 8:20 PM, Michael Liao <michael.liao at intel.com> wrote:
> > On Mon, 2012-08-27 at 17:07 -0700, Matt Beaumont-Gay wrote:
> >> This looks pretty reasonable, but the testcase probably doesn't need
> >> to have a printf call in it.
> >
> > Test case is revised to call an external function instead of printf.
> > please let me know whether it's OK to commit.
> 
> I assume the extern function could just take an __int128 parameter,
> rather than taking a pair of longs and having to jump through hoops to
> produce those arguments. What I'm getting at is that the test case
> should be as simple as possible.

Ah, I originally copied the test case from bug report. Anyway, I
simplified it and committed as r162766. Thanks for review.

Yours
- Michael

> 
> Anyway, LGTM.
> 
> -Matt





More information about the cfe-commits mailing list