[cfe-commits] r162468 - in /cfe/trunk/lib/AST: CXXInheritance.cpp ExprConstant.cpp

[Ted Kremenek]

On Aug 27, 2012, at 2:32 PM, David Blaikie <dblaikie at gmail.com> wrote:

> "Just for fun, I ran a grep for getAs() followed immediately by a
> method call, which turned up 295 cases that should probably be
> castAs(). If this sort of thing should be cleaned up...
> $ git grep -E '(->|\.)getAs<\w+>\(\)->' | wc -l"

Interesting.  Very cute.

> 
> There are a few less with your change, but still a few to clean up. I
> might get to them at some point - but figured I'd record it here
> because it seemed relevant to the change. (perhaps they're also
> interesting to you as areas of improvement for the Static Analyzer if
> it's not correctly flagging them already)

Not sure if the analyzer didn't catch all of these or not, but I suspect it didn't.  I was gradually going through some of the analyzer issues and fixing them.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120827/01a956ad/attachment.html>