[cfe-commits] r162642 - /cfe/trunk/lib/CodeGen/CGExprScalar.cpp

David Blaikie dblaikie at gmail.com
Mon Aug 27 15:04:14 PDT 2012


On Fri, Aug 24, 2012 at 10:43 PM, Richard Smith
<richard-llvm at metafoo.co.uk> wrote:
> Author: rsmith
> Date: Sat Aug 25 00:43:00 2012
> New Revision: 162642
>
> URL: http://llvm.org/viewvc/llvm-project?rev=162642&view=rev
> Log:
> Remove spurious string literal for bool argument.

How'd you come across this? Compiler diagnostic or is it something
we're missing/could add?

>
> Modified:
>     cfe/trunk/lib/CodeGen/CGExprScalar.cpp
>
> Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=162642&r1=162641&r2=162642&view=diff
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/CGExprScalar.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGExprScalar.cpp Sat Aug 25 00:43:00 2012
> @@ -2123,7 +2123,7 @@
>      llvm::BasicBlock *Cont = CGF.createBasicBlock("shl.cont");
>      llvm::BasicBlock *Trap = CGF.getTrapBB();
>      llvm::Value *WidthMinusOne =
> -      llvm::ConstantInt::get(RHS->getType(), Width - 1, "shl.width");
> +      llvm::ConstantInt::get(RHS->getType(), Width - 1);
>      CGF.Builder.CreateCondBr(Builder.CreateICmpULE(RHS, WidthMinusOne),
>                               Cont, Trap);
>      CGF.EmitBlock(Cont);
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list