[cfe-commits] [PATCH] objc_sync_enter and objc_sync_exit function signatures

Aaron Ballman aaron at aaronballman.com
Mon Aug 27 12:23:51 PDT 2012


On Mon, Aug 27, 2012 at 3:19 PM, Joseph Ranieri <joe at alacatialabs.com> wrote:
> While browsing the implementation of @synchronized, I noticed that the
> signatures in Clang for objc_sync_enter and objc_sync_exit didn't
> match the signatures in the objc4 sources on opensource.apple.com
> (http://www.opensource.apple.com/source/objc4/objc4-532/runtime/objc-sync.h).
> Attached is a patch that updates CGObjCMac to correct the return type.
> The rewriter also has this problem, but since I am less familiar with
> the rewriter I have attached it as a separate patch.

I don't know enough about the rewriter to comment aside from saying it
looks sensible.  But the rest LGTM.

~Aaron



More information about the cfe-commits mailing list