[cfe-commits] [PATCH] Add configuration of CLANG_VENDOR, VENDOR_GCC_VERISON

[Sebastian Pop]

Hi Ron,

> @@ -658,7 +659,6 @@ void Driver::PrintHelp(bool ShowHidden) const {
>  void Driver::PrintVersion(const Compilation &C, raw_ostream &OS) const {
>    // FIXME: The following handlers should use a callback mechanism, we don't
>    // know what the client would like to do.
> -  OS << getClangFullVersion() << '\n';
>    const ToolChain &TC = C.getDefaultToolChain();
>    OS << "Target: " << TC.getTripleString() << '\n';
>
> @@ -666,6 +666,8 @@ void Driver::PrintVersion(const Compilation &C, raw_ostream &OS) const {
>    //
>    // FIXME: Implement correctly.
>    OS << "Thread model: " << "posix" << '\n';
> +
> +  OS << getClangFullVersion() << '\n';
>  }
>
>  /// PrintDiagnosticCategories - Implement the --print-diagnostic-categories
>

I don't see a good reason to change the order in which getClangFullVersion is
printed.  Could you explain why you changed this?  Otherwise please revert.

> @@ -718,6 +725,9 @@ bool Driver::HandleImmediateArgs(const Compilation &C) {
>        C.getArgs().hasArg(options::OPT__HASH_HASH_HASH)) {
>      PrintVersion(C, llvm::errs());
>      SuppressMissingInputWarning = true;
> +    if (C.getArgs().hasArg(options::OPT_v)) {
> +      SuppressMissingOptionsWarning = true;
> +    }
>    }

You don't need braces on single statement ifs.


> +dnl Vendor defined Version , GCC Version, and Name

Please remove the space before comma.

Thanks,
Sebastian
-- 
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum