[cfe-commits] [patch] Elided __VA_ARGS__ now erase preceding comma in MS mode

[Aaron Ballman]

On Mon, Aug 27, 2012 at 8:35 AM, Jean-Daniel Dupas
<devlists at shadowlab.org> wrote:
>
> Le 27 août 2012 à 14:31, Aaron Ballman <aaron at aaronballman.com> a écrit :
>
>> On Mon, Aug 27, 2012 at 5:42 AM, Martin Vejnár <Martin.Vejnar at avg.com> wrote:
>>> I’ve beed asked to post this patch to cfe-commits, so there you go. The
>>> preprocessor show now consume a comma before elided __VA_ARGS__ even if
>>> there is no pasting operator in between. E.g.
>>
>> In the future, can you submit as an svn patch since not everyone uses git?
>
> I'm not the patch author, but  git patches can be easily apply in svn using patch -p1 command instead of patch -p0, so I don't get why it is an issue ?

Because not all svn clients were created equal.  ;-)  A lot of folks
on Windows, myself included, don't use the command line for svn -- we
use TortoiseSVN directly from explorer.  It doesn't have the ability
to handle git patches (at least that I've ever heard of).  Also, I've
seen its command line interface fall over on git patches as well
(though it's been a few months, so perhaps things have improved).

~Aaron