[cfe-commits] [PATCH] Modifying BoundNodes to store bindings as void* pointers and use getNodeAs instead of getDeclAs and getStmtAs.

Manuel Klimek reviews at llvm-reviews.chandlerc.com
Sun Aug 26 18:49:05 PDT 2012


  Yes, I actually like that this unifies the "namespace" for the bound nodes. I'm still slightly torn on the complexity vs. usefulness trade-off, but I think this proposal wins.


================
Comment at: google3/third_party/llvm/llvm/tools/clang/include/clang/ASTMatchers/ASTMatchersInternal.h:88
@@ +87,3 @@
+/// We use template specialization on the node base type to enable us to
+/// get at the appropriate NodeBaseType objects and do approrpiate static_casts.
+template <typename BaseType>
----------------
appropriate


http://llvm-reviews.chandlerc.com/D25



More information about the cfe-commits mailing list