[cfe-commits] [Patch 4 of 5] Proposed fix for PR12850

Andy Gibbs andyg1001 at hotmail.co.uk
Wed Aug 22 09:29:00 PDT 2012


Hi,

Attached here is the fourth of five patches for PR12850.

This patch makes some alterations to VerifyDiagnosticConsumer (it seems I
cannot leave it alone!) which are there to enable test-cases to check on
the performance of the cache.  An additional -verify directive, namely

  verify-fncache-stats

is supported which generates a diagnostic note to the user or test-case
which details the number of cache hits, the number of cached entries and
the memory consumption (approximate).  This can be matched then with an
appropriate "expected-note" in a test-case.

I don't know whether people think this is a good way to achieve this,
but I was looking for a way to particularly have the hits/count as part
of test-cases to ensure no unintended performance regressions, and this
seemed the best approach.

I would welcome alternatives if this is not the way to do it.

Cheers
Andy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: part4.diff
Type: application/octet-stream
Size: 5894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120822/f5435974/attachment.obj>


More information about the cfe-commits mailing list