[cfe-commits] [PATCH] Reverted clang-check to fully supported CommandLine Library use-case: global static variables.

[Manuel Klimek]

On Wed, Aug 22, 2012 at 11:00 AM, Alexander Kornienko <alexfh at google.com> wrote:
>>> -class CommandLineClangTool {
>>> +class CommonOptionsParser {
>>>  public:
>>> -  /// Sets up command-line options and help messages.
>>> -  /// Add your own help messages after constructing this tool.
>>> -  CommandLineClangTool();
>>> +  // Intentionally public.
>>
>>
>> "Intentionally public" is nice. Additionally giving the reason would be
>> even better. And, as they are now part of the public interface, they deserve
>> a doxygen comment

I'd just add getters and be done with it :)

Apart from that LGTM.