[cfe-commits] [PATCH] C++11 Range-based Loop Converter

Manuel Klimek reviews at llvm-reviews.chandlerc.com
Thu Aug 23 21:41:23 PDT 2012


  Ok, I think this is a good to go in after the Outside fix...

  Thanks for bearing with me!


================
Comment at: loop-convert/StmtAncestor.h:115
@@ +114,3 @@
+  /// some variable declared within ContainingStmt.
+  bool dependsOnOutsideVariable(const Stmt *Body) {
+    DependsOnOutsideVariable = false;
----------------
Sam Panzer wrote:
> Manuel Klimek wrote:
> > This one especially could need an example or two in the docs :) I find this to be one of the most complex parts of this code.
> I added an example that (I think!) makes it clear what this is trying to protect against.
After an offline chat we came to the conclusion that Outside really means Inside here :) Please change...


http://llvm-reviews.chandlerc.com/D19



More information about the cfe-commits mailing list