[cfe-commits] [PATCH] Allow RecursiveASTVisitor to visit implicit ctor initializers (for which isWritten() returns false)

Manuel Klimek reviews at llvm-reviews.chandlerc.com
Thu Aug 23 21:27:35 PDT 2012


  lgtm minus style nit

  Thanks for pulling out the methods for Matches and PartiallyMatches - much better :)


================
Comment at: unittests/Tooling/TestVisitor.h:114
@@ +113,3 @@
+    for (typename std::vector<ExpectedMatch>::const_iterator
+             it = ExpectedMatches.begin(), end = ExpectedMatches.end();
+         it != end; ++it) {
----------------
Style nit: Caps VarNames.


http://llvm-reviews.chandlerc.com/D26



More information about the cfe-commits mailing list